Fallback to "-text-field" component name for unrecognized input type #11004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using an input type not in the map (such as "email") would cause an exception. This renames the `classification` var to more expressive `componentNameMap`, and turns the map into a whitelist of non-default component names only. Any value of "type" not in that map (or no value for "type") will use the default "-text-field" component name.
|
(Note: This PR is for the |
wycats
added a commit
that referenced
this pull request
May 1, 2015
…ypes Fallback to "-text-field" component name for unrecognized input type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using an input type not in the map (such as
{{input type="email"}}) wouldcause an exception. This renames the
classificationvar to moreexpressive
componentNameMap, and turns the map into a whitelist fornon-default component names only. Any value of "type" not in that map (or
no value for "type") will use the default "-text-field" component name.