Maintain childViews array.
#11211
Closed
Maintain childViews array.
#11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
child-views-maintained
branch
2 times, most recently
from
645d365 to
e473804
Compare
|
I'm having this particular problem.. It's causing the plugin ember-tether yapplabs/ember-tether to throw errors. |
rwjblue
force-pushed
the
child-views-maintained
branch
from
e473804 to
1c68c6b
Compare
|
@krisselden - I updated this PR to make |
krisselden
force-pushed
the
child-views-maintained
branch
3 times, most recently
from
1571eff to
da6c31b
Compare
rwjblue
force-pushed
the
child-views-maintained
branch
from
da6c31b to
a96d337
Compare
* Do not return an `Ember.A` * Reimplement `childViews` for `ContainerView`
rwjblue
force-pushed
the
child-views-maintained
branch
from
a96d337 to
785f9c5
Compare
|
This is no longer needed to prevent the double destruction. I'll update the title/description to explain the intent now. This PR adds |
rwjblue
changed the title
willDestroyElement from being called twice.childViews array.
|
might be related #9733? |
|
this seems to have gone stale, is this something we still want to land? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node-managers ensure that
willDestroyElement(and other hooks) are called properly (by walking the much more preciseview._renderNodetree), having the renderer'swillDestroyElementalso traversechildViewsleads towillDestroyElementgetting called twice in cases other than those forContainerView.Fixes #11077.