[BUGFIX beta] Ensure role attribute is applied to views if present. #11227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `role` attribute was previously being applied manually basically forever, but was removed during the Glimmer view layer rewrite. This commit brings it back, and adds a few tests for both Ember.View and Ember.Component to help ensure we don't forget about it in the future. 😃
rwjblue
added a commit
that referenced
this pull request
May 20, 2015
[BUGFIX beta] Ensure role attribute is applied to views if present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roleattribute was previously being applied manually basically forever, but was removed during the Glimmer view layer rewrite.This commit brings it back, and adds a few tests for both Ember.View and Ember.Component to help ensure we don't forget about it in the future. 😃
Fixes #11215.