[BUGFIX beta] Change the Ember.View global to have a deprecation warning on init #11387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const DeprecatedView = View.extend({ | ||
| init() { | ||
| this._super(...arguments); | ||
| Ember.deprecate(`Ember.View is deprecated. Consult the Deprecations Guide for a migration strategy.`, !!Ember.ENV.ENABLE_LEGACY_VIEW_SUPPORT, { url: 'http://emberjs.com/deprecations/v1.x/#toc_ember-view' }); |
There was a problem hiding this comment.
This is likely annoying, but I would prefer that the flag itself is also private. Can you underscore?
There was a problem hiding this comment.
fine with me! I'll make the change
bantic
force-pushed
the
deprecate-ember-view-global
branch
from
23e0283 to
96281bf
Compare
|
There are many places where the now-deprecated |
…ing on init * Use underscored env variable _ENABLE_LEGACY_VIEW_SUPPORT to remove deprecation. * Change tests that used the Ember.View global directly to import View from "ember-views/views/view" instead Refs emberjs#11377
bantic
force-pushed
the
deprecate-ember-view-global
branch
from
96281bf to
1cfb36d
Compare
mixonic
added a commit
that referenced
this pull request
Jun 9, 2015
[BUGFIX beta] Change the Ember.View global to have a deprecation warning on init
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do:
Refs #11377