Rename LinkView to LinkComponent and deprecate the former #11394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for tackling, this is a great start! I think we need to ensure that calling |
|
Added deprecation on reopen too (not sure if there is a more idiomatic way of doing that) |
|
@cibernox a followup that add a URL and entry in the deprecation guide would be great, but I'll do it this AM if you don't have time. We will be looking at this stuff all day anyway. Thank you! |
mixonic
added a commit
that referenced
this pull request
Jun 10, 2015
…nent Rename LinkView to LinkComponent and deprecate the former
|
@rwjblue This should go into |
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Views are being deprecated and
Ember.LinkViewactually extends Ember.Component since early March.Ember.Viewis still available but throws a deprecation warning when used.