Fix container view hooks #11425
Merged
Fix container view hooks #11425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the failing tests are related to RC/AC deprecations and will be fixed by #11428. I'll rebase once that PR is merged. |
The node-managers ensure that `willDestroyElement` (and other hooks) are called properly (by walking the much more precise `view._renderNode` tree), having the renderer's `willDestroyElement` also traverse `childViews` leads to `willDestroyElement` getting called twice in cases other than those for `ContainerView`.
…e only thing that seems to need this
rwjblue
force-pushed
the
fix-container-view-hooks
branch
from
3448c68 to
6e8e8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11077