[BUGFIX release] Ember.View.views should be present

[teddyzeenny]

Since we are exposing an extended version of the View class (the DeprecatedView), we need to use reopenClass to set properties on the class.

[rwjblue]

I restarted Travis job due to the following failure:

Test failed: collection helper: empty views should be removed when content is added to the collection (regression, ht: msofaer)
Failed assertion: Ember.View.views should be empty, expected: , but was: ember592

[rwjblue]

Thanks for tracking this down. Will likely wait a short amount of time before releasing a 1.13.1 (and we need to get that test passing) in case there are other regressions.

[teddyzeenny]

Looks like fixing Ember.View.views uncovered an unrelated issue. Before this PR, the ember-dev assertion wasn't functional (it would always pass), which allowed the current failing test to pass.

[rwjblue]

Yes, good catch on the failure. I'll try to get that test fixed in a separate PR.

[rwjblue]

(will have to hold off on merging this in the meantime)

[sandstrom]

This was also very convenient for debugging. Keeping some easy method of getting arbitrary view instances would be awesome 😄

[rwjblue]

@teddyzeenny - Can you rebase?

[teddyzeenny]

Rebased. Collection helper test is still failing though.

[ibroadfo]

<3

On Sun, 2 Aug 2015 at 20:33 Robert Jackson notifications@github.com wrote:

Closed #11437 #11437 via #11956
#11956.

—
Reply to this email directly or view it on GitHub
#11437 (comment).