[BUGFIX release] Allow recomputation for helpers with arguments #11445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
changed the title
| let addedDependency = false; | ||
| let l = params.length; | ||
| if (l) { | ||
| for (var i = 0; i < l; i++) { |
There was a problem hiding this comment.
let l = params.length; if(l) { is an unnecessary optimization in modern engines. It won't hurt anything, but nor will it help. See http://jsperf.com/caching-array-length/4 (This is because JITs know how to do this optimization for you -- the two versions often produce the same set of instructions.)
There was a problem hiding this comment.
Sweet, will drop the paranoia :-)
No unit test for helpers exercised the inline expression visitor (all used the content expression) with recomputation. The inline expression visitor links params before calling the inline hook. Linking params sets morph.linkedParams which disallows calling linkParams later with additional dependencies. To work around this, here the morph subscribes to the helperStream in invoke-helper itself if there are any params or hash arguments (which means that there the call is an inline one). The helperStream in turn subscribes to the params and hash.
mixonic
added a commit
that referenced
this pull request
Jun 15, 2015
[BUGFIX release] Allow recomputation for helpers with arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No unit test for helpers exercised the inline expression visitor (all used the content expression) with recomputation. The inline expression visitor links params before calling the inline hook. Linking params sets morph.linkedParams which disallows calling linkParams later with additional dependencies.
To work around this, here the morph subscribes to the helperStream in invoke-helper itself if there are any params or hash arguments (which means that there the call is an inline one). The helperStream in turn subscribes to the params and hash.
/cc @wycats @mmun @jamesarosen