-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452 #11468
[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452 #11468
Conversation
Please also update the breaking changes list in the 2.0 beta blog post :-) |
a01ae46
to
3ee7fc2
Compare
@thejameskyle looks like this needs a rebase |
3ee7fc2
to
934da0f
Compare
Rebased |
Darn it just kicked travis into submission, then noticed this is not flagged correctly. Please |
I don't understand |
@thejameskyle the commit message should be prefixed with '[BUGFIX release]` that way our magically build tool fairy (@rwjblue) knows where it must go. |
934da0f
to
78887a2
Compare
FYI The context for tagging commits is in: https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#pull-requests |
@thejameskyle I think |
@stefanpenner that's a suite, it gets pulled in by other tests. |
Ah good catch. Whats blocking that last checkbox? |
Me trying to finish my conference talk for next week. 😛 |
ah ok. Carryon |
cc @rwjblue |
@rwjblue friendly reminder |
78887a2
to
013f797
Compare
Updated |
[BUGFIX release] Deprecate Freezable and frozenCopy. Resolves #11452
Hold off on merging, putting this up so @stefanpenner can take a look.
Other stuff: