[BUGFIX beta] deprecate this.resource() in Router.map()

[jayphelps]

Use this.route('name', { resetNamespace: true }) instead.

This has been talked about for months, but hadn't seen a PR so figured 2.0 beta it was time.

Back in March, this.resource was removed from the guides and released as 1.11.0.

• Deprecate this.resource()
• Add API docs for resetNamespace
• Add Guide docs for resetNamespace Documents resetNamespace: true guides#373

[jayphelps]

I assume the prod build failed because of deprecation stripping in env=prod. Not sure how to counter this? (without removing the expect(count)) Switched to the more general, top-level expectDeprecation usage. Seemed to fix it locally.

Test failed: Ember Router DSL: should fail when using a reserved route name
    Failed assertion: Expected 12 assertions, but 8 were run

https://travis-ci.org/emberjs/ember.js/jobs/67565607
https://github.com/emberjs/ember.js/pull/11517/files#diff-67ac84b7cb119834ff0e6318cf17cb03L18

[jayphelps]

All green.

[workmanw]

I'm just curious, what's the reason for this? If this.resource is the same as this.route('name', { resetNamespace: true }), why bother?

[jayphelps]

@workmanw core team has their own rationale I'm sure, but IMO it's always been a huge confusion point for new-comers. Like, almost unanimously everyone is confused when I see them learning ember. Since you can nest this.route now, having the explicit resetNamespace: true makes it very more clear what you intended vs. "wtf why isn't ember finding my route/model/template/etc".

The original intent was to have a concept of a resource mapping effectively for things that are models (hence the name) but it just made things more confusing and inconsistently used and abused.

[workmanw]

Gotcha. I hadn't really heard anything about this change and I was curious if there was some other plan for this.route or this.resource.

I often see changes like this and am always curious about the rationale. Not questioning it. Just trying to better understand the motivation for the change.

[jayphelps]

@workmanw this particular case was definitely more informally discussed on IRC/slack/discuss.emberjs.com/etc. It's possible the core team has collectively not agreed to move forward on this, I just happened to be refactoring code and had the cycles to PR.

[rwjblue]

I am in favor of this PR, but there are a few things that will still be needed:

• PR updating guides
• Adding API documentation for resetNamespace

I'll confirm with others, but I believe that this is exactly the direction we have been intending to go...

[jayphelps]

@rwjblue happy to do both once someone confirms this/they will be merged. Thanks!

[jmurphyau]

I'm wondering if somehow, while the Router.map is being discussed, I can sneak in and ask for an opinion on #11308 ...

Might be something for another time - needing more discussion etc - but if not then might be a good time to get two changes in at once or combine it into one PR or something?

Given that resource is to be removed it might mean the idea behind my PR should be implemented differently

[jayphelps]

@jmurphyau IMO definitely a different discussion, although I do like the idea of your PR at first glance!

[jmurphyau]

👍 sweet - sounds good.. Had no activity on it since I opened it and seen this PR as a chance to steal some attention ;)

BTW +1 to route/resource being a pain point.. It was for me.. A resetNamespace option is a much better implementation.

[jayphelps]

Can someone kick saucelabs for me? I believe this is should be green and all requests by @rwjblue for docs should be ready, but IE test timed out

[stefanpenner]

kicked

[rwjblue]

Thanks @jayphelps!

[tim-evans]

As a follow up, could we have an ember-watson task for this?

[rwjblue]

@tim-evans - Seems good to me, would you mind making an issue over in ember-watson repo explaining what needs to be done?