[BUGFIX beta] {{link-to}} before application boot #11522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| registry.register('component-lookup:main', ComponentLookup); | ||
|
|
||
| let component = Ember.Component.extend({ | ||
| layout: compile('{{#link-to "about"}}Go to About{{/link-to}}'), |
There was a problem hiding this comment.
wacky double space after link-to
There was a problem hiding this comment.
Actually @mixonic this is intentional. Many people see code as a dead thing, cold symbols to instruct the unfeeling machine what to do. However, the truth is that code, like any living being, is coursing with energy and its own sense of purpose. Here, I could intuitively feel that the {{link-to}} helper was feeling constrained by being forced into such close proximity with the argument, badly damaging the feng shui of this file.
lol j/k I fixed it
|
lgtm! |
| // This test is designed to simulate the context of an ember-qunit/ember-test-helpers component integration test, | ||
| // so the container is available but it does not boot the entire app | ||
| QUnit.test('Using {{link-to}} does not cause an exception if it is rendered before the router has started routing', function(assert) { | ||
| Router.map(function(match) { |
|
👍 /cc @nathanhammond |
Previously, {{link-to}} would work even if the application had not been
booted completely. This behavior is relied on by test harnesses like
ember-qunit, since an “integration test” of a component may include a
template that uses {{link-to}}. Many people have discovered that they
would like to test a component that has a link without booting the
entire app.
> You wanted a banana but what you got was a gorilla holding the banana
> and the entire jungle. –Joe Armstrong
During the Glimmer work, we refactored the interface between the
LinkComponent and the router into a service. Unfortunately, this
caused a regression where rendering the link before the router was
completely initialized would raise an exception.
This commit adds a very stupid guard to ensure that we have enough
router state to determine if a link is active or not. This whole path
could be significantly cleaned up, and in particular, we should move
towards using a stubbed routing service in tests that encapsulates all
of these concerns.
tomdale
force-pushed
the
fix-link-to-regression
branch
from
378dce8 to
c9dbecb
Compare
rwjblue
added a commit
that referenced
this pull request
Jun 21, 2015
[BUGFIX beta] {{link-to}} before application boot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, {{link-to}} would work even if the application had not been booted completely. This behavior is relied on by test harnesses like ember-qunit, since an “integration test” of a component may include a template that uses {{link-to}}. Many people have discovered that they would like to test a component that has a link without booting the entire app.
During the Glimmer work, we refactored the interface between the LinkComponent and the router into a service. Unfortunately, this caused a regression where rendering the link before the router was completely initialized would raise an exception.
This commit adds a very stupid guard to ensure that we have enough router state to determine if a link is active or not. This whole path could be significantly cleaned up, and in particular, we should move towards using a stubbed routing service in tests that encapsulates all of these concerns.
Fixes #11150.