Revert "Fixes: Safari's 'double finally on error bug'" #11547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 917da11. iOS 6 makes up less the 4% of the iOS market, and this bug appears to be fixed in iOS 6.1. As such the potentially affected devices is quite small. Finally, the bug only comes into play in very specific failure scenarios which are nearly all already handled in backburner.
|
+1, please also call out on the 2.0 breaking changes in the blog post |
do we have an issue tracking that? |
|
No, just the blog post for 2.0-beta |
is there |
1 task
|
Come on man. Here is an issue: emberjs/website#2222 We must document these breaking changes. If you contribute a deprecation or breaking change, it must be documented. |
Thanks, i was merely asking if there was an existing issue that tracked this. |
rwjblue
added a commit
that referenced
this pull request
Jun 26, 2015
…inally-on-error Revert "Fixes: Safari's 'double finally on error bug'"
rwjblue
pushed a commit
that referenced
this pull request
Sep 3, 2016
* Update tests to ensure that the global path must not be `undefined` * Fix issue with `Ember._Renderer` export * Remove `Ember.rewatch` export remnants (it was removed in #9323) * Remove `Ember.apply` export remnants (it was removed in #13655) * Remove `Ember.tryCatchFinally` export remnants (it was removed in #11547)
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
* Update tests to ensure that the global path must not be `undefined` * Fix issue with `Ember._Renderer` export * Remove `Ember.rewatch` export remnants (it was removed in emberjs#9323) * Remove `Ember.apply` export remnants (it was removed in emberjs#13655) * Remove `Ember.tryCatchFinally` export remnants (it was removed in emberjs#11547)
webark
pushed a commit
to webark/ember.js
that referenced
this pull request
Oct 6, 2016
* Update tests to ensure that the global path must not be `undefined` * Fix issue with `Ember._Renderer` export * Remove `Ember.rewatch` export remnants (it was removed in emberjs#9323) * Remove `Ember.apply` export remnants (it was removed in emberjs#13655) * Remove `Ember.tryCatchFinally` export remnants (it was removed in emberjs#11547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 917da11.
iOS 6 makes up less the 4% of the iOS market, and this bug appears to be
fixed in iOS 6.1. As such the potentially affected devices is quite
small. Finally, the bug only comes into play in very specific failure
scenarios which are nearly all already handled in backburner.