[BUGFIX release] Ensure local state can shadow attrs. #11572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially intended to deprecate access to local state (ala proxying to attrs) at this location, but we have decided to hold off on that deprecation until angle bracked component invocation is available. Later in the integration efforts, we added an AttrsProxy to handle most of this functionality for us (when using a View inheritor). In the future, the deprecation will almost certainly be added in the `AttrsProxy` (not `getRoot` hook). --- Prior to this change local state could never use the same name as a value in `attrs` (because the `attrs` always "won"). The else case is still present, when a given template is not backed by a view/component instance.
This was referenced Jun 28, 2015
|
LGTm |
rwjblue
added a commit
that referenced
this pull request
Jun 28, 2015
…attrs [BUGFIX release] Ensure local state can shadow attrs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially intended to deprecate access to local state (ala proxying to attrs) at this location, but we have decided to hold off on that deprecation until angle bracket component invocation is available.
Later in the integration efforts, we added an AttrsProxy to handle most of this functionality for us (when using a View inheritor). In the future, the deprecation will almost certainly be added in the
AttrsProxy(notgetRoothook).Prior to this change local state could never use the same name as a value in
attrs(because theattrsalways "won").The else case is still present, when a given template is not backed by a view/component instance.
Fixes #11559
Fixes #11571