[BUGFIX] Add return statement for extend. #11603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While returning seems fine, I don't see how changing 'init' here changes extend behavior. Can you add a test (both for LinkComponent without a deprecation and LinkView with one)? The test will help me understand the issue better and help us prevent future regressions... |
|
Seems like you might have meant to add the return to the extend a few lines below? |
|
Yep. I did intend that to go a few lines south of where I threw it. :/ Still want a test? Or is that a clear change for correctness? |
nathanhammond
force-pushed
the
nathanhammond-fix-extend
branch
from
69d1c67 to
aac13a8
Compare
Results in the value being `undefined` after an `extend` call.
nathanhammond
force-pushed
the
nathanhammond-fix-extend
branch
from
aac13a8 to
474fbf7
Compare
stefanpenner
added a commit
that referenced
this pull request
Jun 30, 2015
[BUGFIX] Add return statement for extend.
|
LGTM cc @truenorth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results in the value being
undefinedafter anextendcall.