[BUGFIX release] Deprecate immediateObserver
#11677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibernox
force-pushed
the
deprecate_immediate_observer
branch
from
26cd9c0 to
84bbd5c
Compare
* Ember.immediateObserver was already deprecated, but it's prototype extension counterpart wasn't. It's not used internally at all. * Improve beforeObserver deprecations. * I had to improve `Ember.deprecateFunc` to accept an options object
cibernox
force-pushed
the
deprecate_immediate_observer
branch
from
84bbd5c to
b1b5d0b
Compare
|
Thank you! :-D |
| let [message, options, func] = args; | ||
| return function() { | ||
| Ember.deprecate(message, false, options); | ||
| return func.call(this, arguments); |
There was a problem hiding this comment.
I've just spotted this. It should be func.apply(this, arguments), not call :(
stefanpenner
added a commit
that referenced
this pull request
Jul 8, 2015
Re: #11677 (comment) restored by @stefanpenner
stefanpenner
added a commit
that referenced
this pull request
Jul 12, 2015
Re: #11677 (comment) restored by @stefanpenner (cherry picked from commit 5550de1)
stefanpenner
added a commit
that referenced
this pull request
Jul 12, 2015
Re: #11677 (comment) restored by @stefanpenner (cherry picked from commit 5550de1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension counterpart wasn't. It's not used internally at all.
Ember.deprecateFuncto accept an options object. Useful to provide the url of a deprecation