[BUGFIX beta] improve errors when InjectedProperty is misused #11722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is really a bug, but none of the other categories really seem to fit. |
👍 - Thanks for submitting! |
Previously, if InjectedProperty was created improperly, it would fail with an obtuse "undefined has no property type" error. This introduces an assertion to improve the readability of that error case.
jamesarosen
force-pushed
the
injected-property-assert
branch
from
dae01eb to
7a3e967
Compare
|
I had introduced a failing test by fixing a typo. I've re-pushed. |
rwjblue
added a commit
that referenced
this pull request
Jul 12, 2015
[BUGFIX beta] improve errors when InjectedProperty is misused
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if InjectedProperty was created improperly, it would fail with an obtuse "undefined has no property type" error. This introduces an assertion to improve the readability of that error case.
/cc @rwjblue