[BUGFIX beta] [fixes #11736] ensure array computed macro’s have corre… #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ import { isArray } from 'ember-runtime/utils'; | |||
|
|
|||
| function reduceMacro(dependentKey, callback, initialValue) { | |||
| return computed(`${dependentKey}.[]`, function() { | |||
| return get(this, dependentKey).reduce(callback, initialValue); | |||
| return get(this, dependentKey).reduce(callback.bind(this), initialValue); | |||
There was a problem hiding this comment.
let the phantomjs trolling begin (Function.prototype.bind is not available).
There was a problem hiding this comment.
are we not using 2.0? I guess our users may also not be, i'll quickly implement it the lame way.
There was a problem hiding this comment.
@rwjblue any opposition to me upgrading us to use phantomjs 2.0 ?
rwjblue
added a commit
that referenced
this pull request
Jul 14, 2015
[BUGFIX beta] [fixes #11736] ensure array computed macro’s have corre…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct this