[CLEANUP BETA] Remove {{with foo as bar}} support #11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Since this needs to land in the beta cycle, can you prefix your commit with '[CLEANUP BETA]' (there is a little bit of info in the CONTRIBUTING.md for background)? |
|
Looks like this needs a rebase now since #11790 landed. |
pdud
changed the title
|
Added the prefix, updated a couple additional test descriptions away from foo as bar, and rebased. Thanks for the info on the commit prefixes! |
rwjblue
added a commit
that referenced
this pull request
Jul 17, 2015
[CLEANUP BETA] Remove {{with foo as bar}} support
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11780
Thanks again for the Good for New Contributors label – I'm learning lots!