[DOCS beta] Update Ember.deprecate and Ember.warn calls in ember-metal with required options
#11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -648,11 +648,11 @@ export function readOnly(dependentKey) { | |||
| export function deprecatingAlias(dependentKey) { | |||
| return computed(dependentKey, { | |||
| get(key) { | |||
| Ember.deprecate(`Usage of \`${key}\` is deprecated, use \`${dependentKey}\` instead.`); | |||
| Ember.deprecate(`Usage of \`${key}\` is deprecated, use \`${dependentKey}\` instead.`, false, { id: 'ember-metal.deprecating-alias', until: '3.0.0' }); | |||
There was a problem hiding this comment.
This one needs to be tweaked a bit. We need to provide options at the calling site.
Basically, all usage of deprecatingAlias need to be updated, so that the 'id' and 'until' is unique to each deprecated property.
There was a problem hiding this comment.
How about giving deprecatingAlias an options param?
There was a problem hiding this comment.
Yep, sounds exactly correct. Then all the calling sites need to be updated to pass in their own options arg.
|
Looks great, I left some inline comments on tweaks. Thanks for tackling this! |
…metal with required options
|
@rwjblue Updated with tweaks. |
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Jul 21, 2015
…etal [DOCS beta] Update `Ember.deprecate` and `Ember.warn` calls in ember-metal with required options
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11835