Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX canary] Meta refactor #11966

Merged
merged 40 commits into from
Aug 5, 2015
Merged

[BUGFIX canary] Meta refactor #11966

merged 40 commits into from
Aug 5, 2015

Commits on Aug 2, 2015

  1. DRY up meta()

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    a5dcce8 View commit details
    Browse the repository at this point in the history

  2. moving meta into its own module

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    8133291 View commit details
    Browse the repository at this point in the history

  3. make exports consistent

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    3044547 View commit details
    Browse the repository at this point in the history

  4. notes-to-self on each meta property's access patterns

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    ab25153 View commit details
    Browse the repository at this point in the history

  5. encapsulated meta.cache

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    807b963 View commit details
    Browse the repository at this point in the history

  6. generalize upgrade support

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    31c16f0 View commit details
    Browse the repository at this point in the history

  7. more progress on generic meta accessors

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    4bb9009 View commit details
    Browse the repository at this point in the history

  8. encapsulated meta.watching

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    d885f23 View commit details
    Browse the repository at this point in the history

  9. align semantics

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    542765b View commit details
    Browse the repository at this point in the history

  10. lazy watchers

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    a4c9dd3 View commit details
    Browse the repository at this point in the history

  11. encapsulated meta.mixins

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    68895ec View commit details
    Browse the repository at this point in the history

  12. encapsulate meta.bindings

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    aab8f9a View commit details
    Browse the repository at this point in the history

  13. encapsulated meta.values

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    0b96990 View commit details
    Browse the repository at this point in the history

  14. typos

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    bbfb0e7 View commit details
    Browse the repository at this point in the history

  15. extra reusable bits

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    c40512a View commit details
    Browse the repository at this point in the history

  16. encapsulate meta.listeners

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    bab0092 View commit details
    Browse the repository at this point in the history

  17. encapsulate meta.deps

    @ef4
    ef4 committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    9b51c9e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2015

  1. encapsulate meta.chainWatchers

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    1fd3eb5 View commit details
    Browse the repository at this point in the history

  2. encapsulate meta.chains

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    a3f86cc View commit details
    Browse the repository at this point in the history

  3. break the meta prototype chain!

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    93743c1 View commit details
    Browse the repository at this point in the history

  4. better naming

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    d51a492 View commit details
    Browse the repository at this point in the history

  5. better naming for inheritedMap accessors

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    f216afc View commit details
    Browse the repository at this point in the history

  6. better naming for inheritMapOfLists accessors

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    a4a4854 View commit details
    Browse the repository at this point in the history

  7. better naming for inheritedMapOfMaps accessors

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    2d70d56 View commit details
    Browse the repository at this point in the history

  8. better naming for ownCustomObject accessors

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    d748879 View commit details
    Browse the repository at this point in the history

  9. better naming for inheritedCustomObject accessors

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    dbc712c View commit details
    Browse the repository at this point in the history

  10. commenting

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    8886eb7 View commit details
    Browse the repository at this point in the history

  11. spelling, how does it work?

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    45d73c1 View commit details
    Browse the repository at this point in the history

  12. starting some new meta tests

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    26008e0 View commit details
    Browse the repository at this point in the history

  13. point everything at the new meta module

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    c4b3bce View commit details
    Browse the repository at this point in the history

  14. fancy new listener data structures

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    71ebf9c View commit details
    Browse the repository at this point in the history

  15. remove outdated comment

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    84a0a50 View commit details
    Browse the repository at this point in the history

  16. micro-optimize every Object.create(null) to our own EmptyObject

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    7b5fcc0 View commit details
    Browse the repository at this point in the history

  17. fix silly unnecessary defProp

    @ef4
    ef4 committed Aug 3, 2015
    Configuration menu
    Copy the full SHA
    c64b316 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2015

  1. incorporating stef feedback

    @ef4
    ef4 committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    09218cf View commit details
    Browse the repository at this point in the history

  2. use empty object

    @ef4
    ef4 committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    714f0b8 View commit details
    Browse the repository at this point in the history

  3. speed up Meta instantiation 

    6ms -> noise

turns out there is no 0 cost abstraction in JS yet...
    @stefanpenner
    stefanpenner committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    580a40a View commit details
    Browse the repository at this point in the history

  4. don’t event try the for loop if there are no actions

    @stefanpenner
    stefanpenner committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    a64e211 View commit details
    Browse the repository at this point in the history

  5. remove get for an internal property that will never be a CP 

    In one example this removes nearly 8% of gets
    @stefanpenner
    stefanpenner committed Aug 4, 2015
    Configuration menu
    Copy the full SHA
    b6b0739 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2015

  1. Merge pull request #2 from stefanpenner/eds 

    speed up Meta instantiation
    @ef4
    ef4 committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    584fc73 View commit details
    Browse the repository at this point in the history