Allow instanceInitializers to set customEvents.
#12057
Conversation
Instance initializers were previously not able to affect the `customEvents` that will be provided to the `EventDispatcher`. This is most helpful when you are receiving configuration that is registered as in an initiailzer. The fix here is to run instance initializers before the event dispatcher is setup, so that they can augment the `customEvents` hash.
|
👍 This looks good to me. As part of our efforts of not landing new features without docs or guides, we should definitely include this—but I'm not sure exactly where in the docs it should go. @michaelrkn @locks @trek, any ideas? |
|
FWIW, the use case of wanting to change custom events per instance is going to be exceedingly rare. Remember, instances are per-run, which usually means you need special configuration for the current user, for example. The notion of "which events does the DOM generate?" tends to be application-specific, not instance-specific, so |
|
There are existing API docs for |
Then it doesn't belong in the Guides, I don't think. |
|
👍 I'm happy with keeping this feature in the API docs. Maybe someday we can have a kickass 👊 guide for writing addons… but for now, let's focus on apps. |
…vents Allow instanceInitializers to set `customEvents`.
Instance initializers were previously not able to affect the
customEventsthat will be provided to theEventDispatcher. This is most helpful when you are receiving configuration that is registered as in an initiailzer.The fix here is to run instance initializers before the event dispatcher is setup, so that they can augment the
customEventshash.Related to #12056.
Please note this has not worked previously (though from the look of the code, it was intended to), so it is not a
[BUGFIX release]candidate.