Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] improve performance of guidFor when reading an exist… #12061

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

stefanpenner
Copy link
Member

…ing guid

  • This made OrderedSet#add 2x -> 3x faster (really helps our ember-data friends)
  • This appears to have made OrderedSet#add faster then V8 native Set#add (for now – in one specific + common scenario)
  • will help all scenarios where we use guidFor on an object that already has a guid

…ing guid

* This made OrderedSet#add 2x -> 3x faster (helps our ember-data friends)
* This appears to have made OrderedSet#add faster then V8 native Set#add (for now)
rwjblue added a commit that referenced this pull request Aug 12, 2015
[BUGFIX release] improve performance of guidFor when reading an exist…
@rwjblue rwjblue merged commit 9bffc1a into emberjs:master Aug 12, 2015
@rwjblue rwjblue deleted the faster-guid-for-yo branch August 12, 2015 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants