Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates unnecessary dirtying of proxy streams when the
source object is an Ember.Object. It results in significant re-render
performance improvement in certain scenarios, especially when people are
iterating over lists of Ember.Objects to render components with
expensive lifecycle hooks.
We already have a longstanding convention that people need to use
set
to mutate Ember.Objects if they expect any observability, and as long as
people are using
set
, interior mutability will be captured by otherobservers further downstream.
The same is not necessarily true for POJOs. We would like to allow
something conceptually like:
to work correctly, such that the deep mutation gets noticed. Which is
why this change treats POJOs and Ember.Object's differently.
Credit to @wycats for formulating this approach.