[BUGFIX release-1-13] Ensure concat streams unsubscribe properly. #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
oh, awesome! |
rwjblue
force-pushed
the
cleanup-concat-subscription
branch
from
6215c98 to
4211074
Compare
The stream returned by `concat` should subscribe to any input streams so that the "concat stream" is marked as dirty if any of the input streams are dirtied. This is/was working properly. Unfortunately, when `subscribe`ing directly as done in 1.13.0, the subscriptions are never cleared if the "concat stream" is deactivated. This means, that listeners build up over time and leak the "concat streams" and the `KeyStream`'s / `ProxyStream`'s that are in use. Using `stream.addDependency` instead of manually `subscribe`ing allows the returned "concat stream" to properly remove subscribers when it is deactivated.
rwjblue
force-pushed
the
cleanup-concat-subscription
branch
from
4211074 to
dc4fbd9
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 1, 2015
[BUGFIX release-1-13] Ensure concat streams unsubscribe properly.
|
Cherry picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream returned by
concatshould subscribe to any input streams so that the "concat stream" is marked as dirty if any of the input streams are dirtied. This is/was working properly.Unfortunately, when
subscribeing directly as done in 1.13.0, the subscriptions are never cleared if the "concat stream" is deactivated. This means, that listeners build up over time and leak the "concat streams" and theKeyStream's /ProxyStream's that are in use.Using
stream.addDependencyinstead of manuallysubscribeing allows the returned "concat stream" to properly remove subscribers when it is deactivated.Authored by @raytiley / @rwjblue / @mmun.
Fixes #11802.