Breaks circular references in rejected jqXhr promises

[xcambar]

Ember.RSVP.onerrorDefault creates a circular reference to jqXhr instances by ultimately doing:

e.errorThrown.__reason_with_error_thrown__ = e;

It prevents libraries like Sentry to properly handle errors as they usually JSON.stringify stuff and this fails (because circular reference).

Here's an example JSBin : https://emberjs.jsbin.com/kubefos/edit?html,js,output

[xcambar]

From travis, job Node.js: iojs — TEST_SUITE=old-jquery-and-extend-prototypes:

$ nvm install iojs
Installing iojs from source is not currently supported
The command "nvm install iojs" failed and exited with 105 during .

[rwjblue]

Installing iojs from source is not currently supported

Weird. Likely just a fluke.

---

Can you add a test that does something like (pseudo code):

Ember.onerror = function(error) {
  assert.ok(JSON.stringify(error), 'can stringify the error');
};

var error = new Error('whatever');
var rejectReason = { errorThrow: error);

Ember.RSVP.reject(rejectReason);

To ensure we can JSON.stringify?

[stefanpenner]

mutating objects from somewhere else isn't a good idea. Lets instead mark this property as non enumerable at the source.

[stefanpenner]

lets skip the delete, and just mark this property as non enumerable.

Object.defineProperty(error, '__reason__', { value: reason, enumerable: false })

[xcambar]

@rwjblue Done. For readibility, I added an assertion on error.message because a failure in JSON.stringify recalls Ember.onerror with the TypeError: circular reference and a serialization to {}.
It is not necessary for the test itself, but helps in case of failure.

@stefanpenner Absolutely, I was not happy with the delete but simply did not think of defineProperty. Thanks and Done.

[rwjblue]

Looks good to me.

@stefanpenner - r?

[stefanpenner]

why not just Object.defineProperty ? Its a language feature now, since we only support > ES5.

[xcambar]

@stefanpenner Fixed.

[rwjblue]

Awesome, thank you!