[BUGFIX beta] Ensure that this._super is called by Components.
#12396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,9 @@ import { guidFor } from 'ember-metal/utils'; | |||
| import { computed } from 'ember-metal/computed'; | |||
| import { Mixin } from 'ember-metal/mixin'; | |||
| import { POST_INIT } from 'ember-runtime/system/core_object'; | |||
| import { symbol } from 'ember-metal/utils'; | |||
|
|
|||
| let INIT_WAS_CALLED = symbol('INIT_WAS_CALLED'); | |||
rwjblue
force-pushed
the
ensure-init-is-called
branch
from
4babaea to
e239b48
Compare
| @@ -610,6 +613,7 @@ export default Mixin.create({ | |||
| this.scheduledRevalidation = false; | |||
There was a problem hiding this comment.
although not part of this commit, should this assignment to this be before the init ?
There was a problem hiding this comment.
I'm not sure I follow what you mean. This assignment is happening just before this._super is called, do you want to move it afterwards or something else?
There was a problem hiding this comment.
yes, as in ES6 you can't touch this before calling super, we should slowly move our internals to this.
There was a problem hiding this comment.
Updated to call this._super first (before using anything on this).
|
LGTM |
rwjblue
force-pushed
the
ensure-init-is-called
branch
from
e239b48 to
615d79e
Compare
When implementing `init` in a component subclass you must call
`this._super(...arguments)`. If you do not you will get an error.
Unfortunately, that error is **very** hard to understand and is
completely unrelated to code that you have written.
This change adds a small flag (via symbol to avoid exposing this
publicly) that we can use to ensure that `_super` was called
properly.
---
After these changes, given the following:
```javascript
import Ember from 'ember';
export default Ember.Component.extend({
init() {
this.doThings();
}
});
```
Will throw an error that explains that you must call `_super`:
```
You must call `this._super(...arguments);` when implementing `init`
in a component. Please update ${this} to call `this._super` from `init`.
```
rwjblue
force-pushed
the
ensure-init-is-called
branch
from
615d79e to
bf455fb
Compare
You should generally always call `this._super(...arguments);` before touching `this` in the constructor. This requirement is actually enforced by ES2015 classes...
rwjblue
added a commit
that referenced
this pull request
Sep 27, 2015
[BUGFIX beta] Ensure that `this._super` is called by Components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing
initin a component subclass you must callthis._super(...arguments). If you do not you will get an error. Unfortunately, that error is very hard to understand and is completely unrelated to code that you have written.This change adds a small flag (via symbol to avoid exposing this publicly) that we can use to ensure that
_superwas called properly.After these changes, given the following:
Will throw an error that explains that you must call
_super:/cc @ef4