[BUGFIX canary] Ensure components actions function without controller. #12416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On canary we no longer create `controller` and `view` template locals.
Unfortunately, our test suite still pretends that they are there (since
they are added back in by the legacy addons) so all tests pass that were
using `scope.getLocal('controller')` and friends).
This commit adds a test for sending actions that runs without the flags
enabled (the test failed prior to this change), and updates
component-node-manager to provide either `_controller` *OR*
`_targetObject` to the component that is being created.
|
r=@wycats in slack |
rwjblue
added a commit
that referenced
this pull request
Oct 1, 2015
[BUGFIX canary] Ensure components actions function without controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On canary we no longer create
controllerandviewtemplate locals. Unfortunately, our test suite still pretends that they are there (since they are added back in by the legacy addons) so all tests pass that were usingscope.getLocal('controller')and friends).This commit adds a test for sending actions that runs without the flags enabled (the test failed prior to this change), and updates component-node-manager to provide either
_controllerOR_targetObjectto the component that is being created.Fixes #12409.
/cc @tomdale @wycats for review