Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] allow watching of ES5+ Getter #12491

Merged
merged 6 commits into from
Jan 21, 2016

Commits on Jan 7, 2016

  1. [BUGFIX Release] allow watching of ES5+ Getter

    Before this commit MandatorySetter enabled + current property being watched
    resulted in `get` always fetching via meta.values. Although this typically works,
    the default getter for a MandatorySetter already does this, so it is actually redundant.
    
    Going further, when a user defines their own getter this code-path is incorrectly taken,
    instead the original value (which originated from the getter) should be the consulted value
    stefanpenner committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    076e05a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0d7dec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aed80aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68d262a View commit details
    Browse the repository at this point in the history
  5. [BUGFIX beta] MandatorySetter: Restore properties correctly

    * no longer rely on meta to store the value until next set after uninstalling MandatorySetter
    * no longer incorrectly re-set on set to enumerable (enumerability should remain constant)
    * test both enumerable / non-enumerable variants
    stefanpenner committed Jan 7, 2016
    Configuration menu
    Copy the full SHA
    1f8c70b View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2016

  1. Configuration menu
    Copy the full SHA
    4e052ff View commit details
    Browse the repository at this point in the history