Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix processing arguments in rerender #12628

Merged
merged 1 commit into from
Nov 19, 2015

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Nov 19, 2015

Rerendering a dot-syntax closure component failed to update the attributes due
to the shortcut being done too soon.

Fix #12613

myProp: 1,
actions: {
changeValue() { this.incrementProperty(`myProp`); },
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing comma

@rwjblue
Copy link
Member

rwjblue commented Nov 19, 2015

Aside from @mixonic's comments, this looks good. Thanks for tackling @Serabe!

Rerendering a dot-syntax closure component failed to update the attributes due
to the shortcut being done too soon.

Fix emberjs#12613
@Serabe
Copy link
Member Author

Serabe commented Nov 19, 2015

Fixed everything. Thank you @mixonic and @rwjblue

rwjblue added a commit that referenced this pull request Nov 19, 2015
[BUGFIX beta] Fix processing arguments in rerender
@rwjblue rwjblue merged commit f03eab4 into emberjs:master Nov 19, 2015
@rwjblue
Copy link
Member

rwjblue commented Nov 19, 2015

Thanks again @Serabe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants