Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NaN as a falsey value in the with helper's docstring #12664

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-htmlbars/lib/helpers/with.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import shouldDisplay from 'ember-views/streams/should_display';
for semantic clarity as it allows you to retain default scope or to reference a property from another
`{{with}}` block.

If the aliased property is "falsey", for example: `false`, `undefined` `null`, `""`, `0` or
If the aliased property is "falsey", for example: `false`, `undefined` `null`, `""`, `0`, NaN or
an empty array, the block will not be rendered.

```handlebars
Expand Down