Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix FastBoot URL parsing crash #12705

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Conversation

tomdale
Copy link
Member

@tomdale tomdale commented Dec 11, 2015

No description provided.

@@ -1810,8 +1810,9 @@
}
},
"emberjs-build": {
"version": "0.5.3",
"from": "emberjs-build@0.5.3",
"version": "0.5.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this back to the current values? emberjs-build was updated to fix bugs in minification

@tomdale
Copy link
Member Author

tomdale commented Dec 11, 2015

@rwjblue fixed (I think)

@@ -2693,7 +2694,8 @@
},
"htmlbars": {
"version": "0.14.8",
"from": "htmlbars@0.14.8"
"from": "htmlbars@0.14.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This states 0.14.8 but you updated package.json to 0.14.9.

@tomdale
Copy link
Member Author

tomdale commented Dec 11, 2015

@rwjblue Still can't believe how clownshoes npm continues to be. Should be fixed now I hope.

rwjblue added a commit that referenced this pull request Dec 11, 2015
[BUGFIX beta] Fix FastBoot URL parsing crash
@rwjblue rwjblue merged commit 039167c into master Dec 11, 2015
@rwjblue rwjblue deleted the fix-fastboot-crash branch December 11, 2015 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants