Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Update HTMLBars #12706

Merged

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Dec 12, 2015

Add support for Glimmer components whose name has a dot.

Please, can someone check this? I cannot install dependencies using the npm-shrinkwrap file but I can install them without it.

Furthermore, I don't know which prefix to use for this PR. [BUGFIX canary]? [BUGFIX beta]?

@rwjblue
Copy link
Member

rwjblue commented Dec 12, 2015

BUGFIX beta is good, even though it doesn't really help/tweak beta (since glimmer components are not enabled in beta), but I'd like to keep beta branch close with the latest htmlbars release for further bug fixes.

Add support for Glimmer components whose name has a dot.
@Serabe Serabe force-pushed the feature/upgrade-htmlbars-contextual-components branch from c686e07 to 55e3723 Compare December 12, 2015 13:33
@Serabe Serabe changed the title Update HTMLBars [BUGFIX beta] Update HTMLBars Dec 12, 2015
@Serabe
Copy link
Member Author

Serabe commented Dec 12, 2015

Done!

rwjblue added a commit that referenced this pull request Dec 12, 2015
…tual-components

[BUGFIX beta] Update HTMLBars
@rwjblue rwjblue merged commit 302247a into emberjs:master Dec 12, 2015
@rwjblue
Copy link
Member

rwjblue commented Dec 12, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants