[WIP][BUGFIX Beta] Positional param clash on rerender of contextual component helper #12711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a fix, but I'm not sure if it's a nice fix. |
|
I'll take a look at this this evening (UTC+2) |
Serabe
added a commit
to Serabe/ember.js
that referenced
this pull request
Dec 14, 2015
If we merge positional and hash parameters without duplicating the hash before, then we get an error when rerendering. Fixes test in emberjs#12711
Serabe
added a commit
to Serabe/ember.js
that referenced
this pull request
Dec 20, 2015
If we merge positional and hash parameters without duplicating the hash before, then we get an error when rerendering. Fixes test in emberjs#12711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the diff for what is happening exactly.
This started raising
You cannot specify both a positional param (at position 0) and the hash argument 'propertyName'anytime something updated after the initial render.I (not yet) have a clue how to fix this, so either a fix or some pointers how to fix would be welcome!