Cleanup router & DSL processing. #12749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +133,18 @@ var EmberRouter = EmberObject.extend(Evented, { | |||
| return get(this, 'location').getURL(); | |||
| }), | |||
|
|
|||
| _isModuleBasedResolver() { | |||
There was a problem hiding this comment.
As an instance method on the router, _isModuleBasedResolver() might be named more clearly as _hasModuleBasedResolver() or even simply _moduleBasedResolver().
|
LGTM besides that one naming nit. |
* Remove manual threading of `moduleBasedResolver`. As of the most recent resolver changes we can directly ask the "real" resolver when we need to. This avoids poluting a bunch of places with `moduleBasedResolver` that do not care about that flag. * Prevent creating additional closure just to create application route. * Avoid manually recreating input options for each layer of DSL (just pass options down). * Make DSL creation a separate function.
rwjblue
force-pushed
the
router-cleanup
branch
from
62274bc to
dac7917
Compare
rwjblue
added a commit
that referenced
this pull request
Dec 23, 2015
Cleanup router & DSL processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleBasedResolver. As of the mostrecent resolver changes we can directly ask the "real" resolver when
we need to. This avoids poluting a bunch of places with
moduleBasedResolverthat do not care about that flag.pass options down).
No public API changes, only small refactoring to clean up some things that I saw while making a plan for Engine work...