Support jQuery versions 1.12 and 2.2

[thijsvdanker]

The 1.12.0 and 2.2.0 release of jQuery have been tagged a couple of hours ago.
The regex for checking jQuery versions for Ember Views didn't pass for 1.12.x or 2.2.x

[blimmer]

👍 this just started causing me problems, too. Should we consider locking the version down in ember-cli bower.json blueprint ? If we don't do that 1.13.x of jQuery will cause this same problem.

[stefanpenner]

embers test suite needs to also run against this (and pass) before we will consider merge.

[rwjblue]

Basically, update https://github.com/emberjs/ember.js/blob/master/bower.json#L8 to use 1.12

[thijsvdanker]

When running TEST_SUITE=all npm test locally I get

Error: Could not find module ember-dev/test-helper/index


  http://localhost:13141/ember-template-compiler.js:58 in missingModule
  http://localhost:13141/ember-template-compiler.js:80 in internalRequire
  http://localhost:13141/ember-template-compiler.js:44 in requireModule
  http://localhost:13141/tests/?skipPackage=container,ember-testing,ember-debug&dist=min&prod=true:135


Test failed: global failure

    Failed assertion: Error: Could not find module ember-dev/test-helper/index
http://localhost:13141/ember-template-compiler.js:58


Took 8ms to run 1 tests. 0 passed, 1 failed.

Failed!
npm ERR! Test failed.  See above for more details.

[thijsvdanker]

But I'm getting the same error when running it with jQuery 1.11.3 so this might error not be related to this PR.

[thijsvdanker]

I am also getting that error when testing the master branch and the release-2-1 branch so that's something in my environment.

Not really sure how to push forward on this one.

[thijsvdanker]

They've just made a blog post about the new releases, maybe the changelogs helps someone in pin-pointing this issue?
http://blog.jquery.com/2016/01/08/jquery-2-2-and-1-12-released/

[lordpixel]

In my case I'm getting the following errors:

Uncaught Error: Assertion Failed: Ember Views require jQuery between 1.7 and 2.1
Uncaught Error: Could not find module ember imported from x/app

As a temporary solution I did:

• Remove the ^ from my jQuery dependency in bower.js (is now "jquery": "1.11.3")
• Remove bower_components folder
• Perform a bower install

I hope this serves as a temporary remedy while we Ember's team provides a definitive solution.

Thank you!

[ryanhollister]

Can I ask the hypothetical question of, "What if the assert is just removed?". Bower and NPM seem better suited to manage/resolve dependencies. People manually managing dependencies management will just have to read the documentation if there comes a time ember is not compatible with a new version of jquery.

[rwjblue]

I would like to see one of these two things happen:

• Remove the assertion completely.
• Change the assertion to match minimum supported jQuery version. This would address the original issue that caused us to add the assertion in the first place.

I would prefer to simply remove the assertion...

[alexspeller]

👍 on removing the assertion, it seems like it's a bit of a hangover from before the ember-cli world, I believe in any case using ember outside of ember-cli when bower is controlling versions is an advanced usecase anyway so the assertion is less useful

[rwjblue]

#12793 removes the assertion

[blimmer]

@thijsvdanker @rwjblue I just bumped to jQuery 1.12 and ran the Ember test suite locally without failures.

[stefanpenner]

#12793

[homu]

☔ The latest upstream changes (presumably #12793) made this pull request unmergeable. Please resolve the merge conflicts.