Make dependencies that end in @each expand to [].
#12848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. There is a separate issue tracking the |
|
Actually #12847 adds the warning for nested |
|
👍 |
|
@rwjblue ya seems like we whichever we merge, the other will need to update. r+ |
|
Ya, I'll land this one first because I need to backport it a ways... |
rwjblue
added a commit
that referenced
this pull request
Jan 20, 2016
Make dependencies that end in `@each` expand to `[]`.
|
FYI - I'll be pulling this into 1.13, 2.1, 2.2, 2.3, 2.4-beta branches. |
|
Cherry picked into beta and release branches. |
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe should also add an assertion about
/@each\..*\./to this, but likely should be a separate PR.