Add deprecation for legacy addons #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
deprecate-legacy-addons
branch
from
0ff95b4 to
5c80180
Compare
rwjblue
added a commit
that referenced
this pull request
Feb 29, 2016
Add deprecation for legacy addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a deprecation warning when we detect that the legacy view/controller
addons are enabled. Since these addons enable "hidden" features, users should
remove the addons from their applications even if they are not hitting the
existing deprecation paths (e.g.
Ember.View#init), so that they can be surethat their applications will continue to work after we drop support for the
addons.