[Glimmer2] Port {{#each-in}} tests #13136
Conversation
| this.assertStableRerender(); | ||
| } | ||
|
|
||
| [`@test it renders the inverse block when given a falsy value`]() { |
There was a problem hiding this comment.
Can we test this by subclassing BasicConditionalsTest like https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/tests/integration/syntax/each-test.js#L14 ?
mmun
force-pushed
the
port-each-in-tests
branch
from
21d5b92 to
9210251
Compare
|
Updated. |
| } | ||
| }); | ||
|
|
||
| this.assertStableRerender(); |
There was a problem hiding this comment.
Can you move assertStableRerender after assertHTML? (After a brief pause, I realize they are isomorphic because assertStableRerender takes a snapshot and assert that they are the same, but the "initial render -> assert result -> assertStableRerender" flow matches other test cases and make the intention more clear.)
There was a problem hiding this comment.
Yes, my bad. I should have left it how it was!
|
Added some comments about the INUR test pattern, otherwise looks great 👀 |
|
(I added a few FIXMEs in |
mmun
force-pushed
the
port-each-in-tests
branch
from
9210251 to
b9f30cf
Compare
mmun
force-pushed
the
port-each-in-tests
branch
from
b9f30cf to
124c5be
Compare
|
@chancancode Ready for another round of review! I added a couple comments in the parts where we force a |
[Glimmer2] Port {{#each-in}} tests
Part of #13127.
assertStableRerenderhelper because it was a pattern I kept reusing.cc @chancancode.