[Glimmer2] Remove tagless-view-tests #13146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 tasks
chancancode
added a commit
that referenced
this pull request
Mar 21, 2016
[Glimmer2] Remove tagless-view-tests
|
✂️ ✂️ ✂️ |
|
We should ensure we have tests for these descriptions. The implementations all tested {{if}} and {{each}}, but the important thing was that given a tagless view it can add remove children. AFAIK, this is not supported in glimmer2 yet... |
chadhietala
added a commit
to chadhietala/ember.js
that referenced
this pull request
Mar 21, 2016
This adds a shared test that follows I-N-U-R for adding and removing children. These types of tests were removed in emberjs#13146. Part of emberjs#13127 /cc @rwjblue @chancancode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be covered by
ember.js/packages/ember-glimmer/tests/utils/shared-conditional-tests.js
Line 709 in bab4447
Part of #13127
/cc @chancancode