Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX RELEASE] Do not refresh routes on initial transition #13218

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

raytiley
Copy link
Contributor

Refreshing the route heighercy do to query param change on the initial transition is pointless, so now we only call refresh if there is a currentState. This fixes #10945

Refreshing the route heighercy do to query param change on the initial transition is pointless, so now we only call refresh if there is a `currentState`. This fixes emberjs#10945
@rwjblue
Copy link
Member

rwjblue commented Mar 30, 2016

LGTM

@rwjblue rwjblue merged commit dd58346 into emberjs:master Mar 31, 2016
@rwjblue rwjblue deleted the qp-initial-refresh branch March 31, 2016 18:48
@rwjblue
Copy link
Member

rwjblue commented Mar 31, 2016

Thanks @raytiley!

@stefanpenner
Copy link
Member

@mike-north does this fix the bug you found?

@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2016

Included in v2.4.4.

@mike-north
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router transition.retry with refreshModel queryParams causes unexpected transition sequence
4 participants