Deprecate usage of {{render helper with a model param
#13268
Conversation
| @@ -0,0 +1,54 @@ | |||
| import { deprecate } from 'ember-metal/debug'; | |||
There was a problem hiding this comment.
Small nit-pick, but this file doesn't transform anything. Can you rename to deprecate-render-model.js instead?
There was a problem hiding this comment.
Yeah, I was wondering about that (the best name for the file).
|
This is looking great, thanks for tackling! I left a few comments inline for tweaks/suggestions, and when you are done can you squash commits? We will also need a PR to the website repo adding this deprecation to the list for Ember 2.6. |
pittst3r
force-pushed
the
render-model-param-deprecation
branch
from
45f6720
to
87691e3
Compare
pittst3r
force-pushed
the
render-model-param-deprecation
branch
from
87691e3
to
39c71b4
Compare
|
@rwjblue No problem, it was fun. Made the requested changes. I'll work on the website update later/tomorrow. |
|
|
||
| deprecate(deprecationMessage(moduleName, node, param), false, { | ||
| id: 'ember-template-compiler.deprecate-render-model', | ||
| until: '3.0.0' |
There was a problem hiding this comment.
Whoops! I just realized that this doesn't include the URL from the website PR. Can you submit a follow up to add that in?
Addresses first part of #13183.
This is my first time diving into Ember internals like this, so I'm pretty sure it won't be 100% off the bat. Also not sure about how to tag this.