[BUGFIX beta] Allow numeric keys for the `get` keyword #13311

duggiefresh · 2016-04-12T02:09:03Z

duggiefresh · 2016-04-12T02:10:00Z

Calling toString() here because of this assertion. Let me know if there's a better direction. Thanks!

rwjblue · 2016-04-12T02:15:12Z

packages/ember-htmlbars/tests/helpers/each_test.js

@@ -471,6 +471,24 @@ QUnit.test('a numeric key can be used with {{each}}', function() {
  equal(view.$().text(), '123');
 });

+QUnit.test('numeric keys work with the `get` keyword', function() {


Test should be added in https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/tests/integration/helpers/get-test.js (using that new format). That file is symlinked to ember-htmlbars tests so that it runs under both glimmer and htmlbars rendering engines.

See #13127 for a detailed description of that test format (and the I-N-U-R test cycle we are using in the ember-glimmer test suite).

Oh yes! Thanks 💚

duggiefresh · 2016-04-12T15:46:24Z

Updated per review. I made an update to Glimmer util/references that will "stringify" numeric keys.

Thanks!

chancancode · 2016-04-12T18:40:23Z

packages/ember-htmlbars/lib/keywords/get.js

@@ -35,8 +35,10 @@ let DynamicKeyStream = BasicStream.extend({

  key() {
    let key = this.keyDep.getValue();
-    if (typeof key === 'string') {
+    if (typeof key === 'symbol') {


Can you add a test for this? (If the browser supports it?)

if (supportsNativeSymbols) { moduleFor('Helpers test: {{get}} with symbols', class extends RenderingTest { // ... }); }

Can do! Is there an example somewhere of how to check for browser support within tests? Thanks

I think something like what I mentioned above should work:

moduleFor('Helpers test: {{get}}', class extends RenderingTest { // current tests } if (typeof Symbol === 'function') { // I think? moduleFor('Helpers test: {{get}} with symbols', class extends RenderingTest { // moar tests }); }

Thanks for the help. However, it seems there isn't support for symbols in templates. Do we want to add symbol support for the {{get}} keyword?

For example, something like this doesn't work either:

['@test should be able to get an object value with numeric keys']() { let first = Symbol('first'); let second = Symbol('second'); let third = Symbol('third'); this.render(`{{#each indexes as |index|}}[{{get items index}}]{{/each}}`, { indexes: [first, second, third], items: { [first]: 'First', [second]: 'Second', [third]: 'Third' } }); °°°

No, if we don't support symbols already in template-land, then we don't need to support it explicitly here.

Great! Thanks will update the PR as necessary

duggiefresh · 2016-05-11T00:07:30Z

Sorry to bother, but just a ping to move this along.

Please see: #13311 (comment)

Thanks, @chancancode @rwjblue

krisselden · 2016-05-14T04:54:55Z

I don't understand why we don't check for number and coerce it? Can we start conservatively? Does it make sense to toString anything? This will toString null to 'null' for example.

krisselden · 2016-05-14T04:57:00Z

Especially if this is targeted as a bugfix to beta.

mixonic · 2016-06-26T17:29:30Z

@duggiefresh I think there was interest in removing the symbol specific code here? /cc @rwjblue

And @krisselden's suggestion re: swapping to a conservative approach, only coercing numbers, seems reasonable.

Would love to see this land :-)

duggiefresh · 2016-06-26T18:03:01Z

@mixonic Thanks for pinging me on this. I believe I'll be attending your Contributors Workshop at WGE. Perhaps, we can land this before the conference. :)

See you then

Fixes emberjs#13296

duggiefresh · 2016-07-08T00:48:28Z

Updated per comments! I removed the symbol references and am now coercing number keys. Thanks 🍨

duggiefresh · 2016-07-13T02:58:01Z

ping @mixonic @krisselden Thank you!

Turbo87 · 2016-07-13T08:46:48Z

does this work for 0 as a key too? I know I can use firstObject too, but in a index-loop it would be easier if 0 would work too.

mixonic · 2016-07-13T17:27:38Z

@Turbo87 I'm not quite sure what you're asking. Can you provide an example?

mixonic · 2016-07-13T17:28:40Z

packages/ember-glimmer/lib/utils/references.js

@@ -127,6 +127,11 @@ export class PropertyReference extends CachedReference { // jshint ignore:line
  }

  get(propertyKey) {
+    if (typeof propertyKey === 'number') {
+      // Allows us to get numeric keys
+      propertyKey = '' + propertyKey;


I kind of expect you would only need the logic in the keyword. What other use-cases does this cover?

I added the coercion here too, because of the assertion here: https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/property_get.js#L49

Turbo87 · 2016-07-13T17:31:43Z

@mixonic I'm talking about something like

{{#each someArray as |value index|}}
  value: {{get some.other.array index}}
{{/each}}

krisselden · 2016-07-13T17:47:51Z

packages/ember-htmlbars/lib/keywords/get.js

@@ -37,6 +37,8 @@ const DynamicKeyStream = BasicStream.extend({
    let key = this.keyDep.getValue();
    if (typeof key === 'string') {
      return key;
+    } else if (typeof key === 'number') {
+      return '' + key;


can you explain why it is needed to be check in both places?

I added a coercion in both ember-glimmer and ember-htmlbars because of the assertion here: https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/property_get.js#L49

Perhaps there's a better place to add this logic?

homu · 2016-08-11T05:13:23Z

☔ The latest upstream changes (presumably #14041) made this pull request unmergeable. Please resolve the merge conflicts.

locks · 2016-11-08T07:47:40Z

@duggiefresh are you able to rebase and solve the conflicts? Thank you!

tsteuwer · 2017-05-14T01:13:37Z

Pease let this happen. I have to manually change keys to strings to use get with them 😊

rwjblue · 2017-06-16T16:51:52Z

I rebased and updated to work on master, but this PR predates github's feature that allows project maintainers to push to PR branches. I resubmitted (with correct commit attribution) in #15366.

rwjblue reviewed Apr 12, 2016
View reviewed changes

duggiefresh force-pushed the 13296-allow-numeric-keys-for-get branch from 0ef6256 to a62d83c Compare April 12, 2016 15:44

duggiefresh force-pushed the 13296-allow-numeric-keys-for-get branch from a62d83c to ad368af Compare April 12, 2016 15:47

rwjblue mentioned this pull request Apr 12, 2016

[Glimmer 2] Allow for null lookups on get to fail gracefully #13317

Merged

chancancode reviewed Apr 12, 2016
View reviewed changes

mixonic added Bug Needs Submitter Response labels Jun 26, 2016

[BUGFIX beta] Allow numeric keys for the get keyword

a7cb4ac

Fixes emberjs#13296

duggiefresh force-pushed the 13296-allow-numeric-keys-for-get branch from ad368af to a7cb4ac Compare July 8, 2016 00:47

mixonic reviewed Jul 13, 2016
View reviewed changes

krisselden reviewed Jul 13, 2016
View reviewed changes

Serabe added Needs Team Response and removed Needs Submitter Response labels Jul 22, 2016

locks added Needs Submitter Response and removed Needs Team Response labels Nov 8, 2016

locks self-assigned this Apr 16, 2017

rwjblue mentioned this pull request Jun 16, 2017

[BUGFIX beta] Allow numeric keys for the get helper. #15366

Merged

rwjblue closed this Jun 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUGFIX beta] Allow numeric keys for the `get` keyword #13311

[BUGFIX beta] Allow numeric keys for the `get` keyword #13311

duggiefresh commented Apr 12, 2016

duggiefresh commented Apr 12, 2016

rwjblue Apr 12, 2016

duggiefresh Apr 12, 2016

duggiefresh commented Apr 12, 2016

chancancode Apr 12, 2016

chancancode Apr 12, 2016

duggiefresh Apr 12, 2016

chancancode Apr 12, 2016

duggiefresh Apr 13, 2016

rwjblue May 11, 2016

duggiefresh May 11, 2016

duggiefresh commented May 11, 2016

krisselden commented May 14, 2016

krisselden commented May 14, 2016

mixonic commented Jun 26, 2016

duggiefresh commented Jun 26, 2016

duggiefresh commented Jul 8, 2016

duggiefresh commented Jul 13, 2016

Turbo87 commented Jul 13, 2016

mixonic commented Jul 13, 2016

mixonic Jul 13, 2016

duggiefresh Jul 14, 2016

Turbo87 commented Jul 13, 2016

krisselden Jul 13, 2016

duggiefresh Jul 14, 2016

homu commented Aug 11, 2016

locks commented Nov 8, 2016

tsteuwer commented May 14, 2017

rwjblue commented Jun 16, 2017

[BUGFIX beta] Allow numeric keys for the get keyword #13311

[BUGFIX beta] Allow numeric keys for the get keyword #13311

Conversation

duggiefresh commented Apr 12, 2016

duggiefresh commented Apr 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duggiefresh commented Apr 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duggiefresh commented May 11, 2016

krisselden commented May 14, 2016

krisselden commented May 14, 2016

mixonic commented Jun 26, 2016

duggiefresh commented Jun 26, 2016

duggiefresh commented Jul 8, 2016

duggiefresh commented Jul 13, 2016

Turbo87 commented Jul 13, 2016

mixonic commented Jul 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Turbo87 commented Jul 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

homu commented Aug 11, 2016

locks commented Nov 8, 2016

tsteuwer commented May 14, 2017

rwjblue commented Jun 16, 2017

[BUGFIX beta] Allow numeric keys for the `get` keyword #13311

[BUGFIX beta] Allow numeric keys for the `get` keyword #13311