[BUGFIX beta] Fix subexpr {{if}} / {{unless}} to use protocol.
#13359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the inline `{{if` / `{{unless` helpers would not
recalulate at the same time as the non-inline versions (because they
were not respecting the `isTruthy` and `.length` checks properly).
This fixes that by properly wrapping the generated stream with those
dependencies (sharing the same code as the block versions of `{{if` /
`{{unless`).
The tests for this were already written, but disabled when running under
HTMLBars. This enables them for running properly in both HTMLBars and
Glimmer engines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the inline
{{if/{{unlesshelpers would not recalulate at the same time as the non-inline versions (because they were not respecting theisTruthyand.lengthchecks properly).This fixes that by properly wrapping the generated stream with those dependencies (sharing the same code as the block versions of
{{if/{{unless).The tests for this were already written, but disabled when running under HTMLBars. This enables them for running properly in both HTMLBars and Glimmer engines.
Fixes #11701.