[BUGFIX] Fix blockless component meta resolution #13634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rwjblue |
|
Can you add another local lookup test that ensures a tagless and block less component can use local lookup (and is able to rerender)? |
|
@rwjblue How do you write a blockless component that uses local lookup? My understanding is that the component has to define a template where a local lookup occurs, and if there's a template, there's a block. |
Ensure that tagless, blockless components can render properly and can still use local lookup
asakusuma
force-pushed
the
template-meta-fix
branch
from
ec0fd27
to
3504332
Compare
|
Thanks for the added test, I was just concerned about this case (but its nice to have more tests). This LGTM when green... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13494
Closes #13632.