Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ember-application-engines] Enable loading and error substates for mounts #13818

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

trentmwillis
Copy link
Member

Reference: ember-engines/ember-engines#103

One open question, how shold substates work when used in conjunction with resetNamespace (with either mount or route)? In other words if I have:

Router.map(function() {
  this.route('news', function() {
    this.{mount|route}('blog', { resetNamespace: true });
  });
});

Should the path to the substate then be: blog_loading or news.blog_loading? I feel like it should be blog_loading but in the current checks the namespace is always applied (see here), so it will look for news.blog_loading even if resetNamespace is applied. Seems like maybe this a bug? If so, I can fix that while I'm in here.

cc @rwjblue @dgeb @nathanhammond

@rwjblue
Copy link
Member

rwjblue commented Jul 15, 2016

@trentmwillis - Yes, I agree that this is a bug.

@dgeb
Copy link
Member

dgeb commented Jul 15, 2016

Yep, I agree that it's a bug as well. It's not specific to engines, so let's address this in a separate PR.

@trentmwillis given that, are you comfortable removing the "WIP" label so we can land this?

@trentmwillis
Copy link
Member Author

I need to make some minor adjustments, but will do that this evening.

@trentmwillis trentmwillis changed the title [WIP FEATURE ember-application-engines] Enable loading and error substates [FEATURE ember-application-engines] Enable loading and error substates for mounts Jul 15, 2016
@trentmwillis
Copy link
Member Author

@dgeb updated, should be good to merge once tests finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants