[FEATURE ember-application-engines] Enable loading and error substates for mounts #13818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ember-engines/ember-engines#103
One open question, how shold substates work when used in conjunction with
resetNamespace
(with eithermount
orroute
)? In other words if I have:Should the path to the substate then be:
blog_loading
ornews.blog_loading
? I feel like it should beblog_loading
but in the current checks the namespace is always applied (see here), so it will look fornews.blog_loading
even ifresetNamespace
is applied. Seems like maybe this a bug? If so, I can fix that while I'm in here.cc @rwjblue @dgeb @nathanhammond