[BUGFIX beta] attributeBindings not working with role
#14009
Conversation
| @@ -186,7 +186,7 @@ function normalizeComponentAttributes(component, attrs) { | |||
| } | |||
| } | |||
|
|
|||
| normalized.role = buildStatement('get', 'ariaRole'); | |||
| normalized.role = normalized.role || buildStatement('get', 'ariaRole'); | |||
There was a problem hiding this comment.
I think you can remove the || by moving the original line up above line 160. That way we always set normalized.role and only if you happen to add an attributeBinding for it would it override (on line 185).
Can you test to see if that fixes the failing test?
There was a problem hiding this comment.
Hmm. I see that this is what @krisselden suggested in #14007.
Seems good to me.
There was a problem hiding this comment.
However it seems a bit confusing that there is two ways of achieving the same thing. ariaRole="foo" or role="foo" + attributeBindings.
I think that it should be only one blessed approach and the other one should be deprecated.
There was a problem hiding this comment.
I'm getting a failure of the ability to change ariaRole once set in v3 beta 1.
See here, all tests are passing on Travis apart from one
https://travis-ci.org/zestia/ember-select-box/jobs/352537510
Should I be using ariaRole, or role?
Edit Scratch that, I just changed it to use role and now it's passing fine.
|
Just wanted to confirm that this is working properly in 2.7, but not 2.8. If 2.7 were also broken we would need |
|
2.7 is fine, this bug is only in beta and canary |
Closes #14007