Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] fillIn only sets value to first match. #14033

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Aug 5, 2016

Currently, fillIn sets the new value to all matches, though the events are
only fired for the first one, making Ember only aware of that one.

This can cause a problem while trying to debug a test.

Fixes #14018

Currently, `fillIn` sets the new value to all matches, though the events are
only fired for the first one, making Ember only aware of that one.

This can cause a problem while trying to _debug_ a test.

Fixes emberjs#14018
@Serabe
Copy link
Member Author

Serabe commented Aug 5, 2016

IMHO, fillIn should raise an error if more than one element matches (like the Capybara::Ambiguous error). I understand that that would be backwards incompatible and would need to wait until 3.0 or to be added to the Grand Testing Unification RFC

@rwjblue
Copy link
Member

rwjblue commented Aug 5, 2016

@Serabe - Good point RE: ambiguous match. Can you comment on the RFC about that so I remember to incorporate it?

@Serabe
Copy link
Member Author

Serabe commented Aug 5, 2016

Thank you. Just did!

@rwjblue
Copy link
Member

rwjblue commented Aug 5, 2016

Also, this is good to go once CI passes. Though at some point (hopefully soon) I need to come back and remove the remaining jQuery usage in the acceptance test helper stuff. We switched to native events (which is awesome), but still have some jQueryisms in here to fix.

@rwjblue rwjblue merged commit 3532546 into emberjs:master Aug 5, 2016
@rwjblue
Copy link
Member

rwjblue commented Aug 5, 2016

Thanks again @Serabe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants