Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLIMMER] Ensure willClearRender is called. #14090

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 19, 2016

This hook is somewhat silly at this point, since the entire purpose makes very little sense today, but it is still invoked in HTMLBars (right after willDestroyElement) so we should keep it around for Glimmer2 as well.

I am absolutely in favor of deprecating and removing in future iterations.

This hook is somewhat silly at this point, since the entire purpose
makes very little sense today, but it is still invoked in HTMLBars
(right after `willDestroyElement`) so we should keep it around for
Glimmer2 as well.

I am absolutely in favor of deprecating and removing in future
iterations.
@rwjblue rwjblue merged commit e150088 into emberjs:master Aug 19, 2016
@rwjblue rwjblue deleted the will-clear-render branch August 19, 2016 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant