Add @since doc tags to everything in Ember.Route that didn't already have it #14341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
approved these changes
Sep 30, 2016
Contributor
locks
left a comment
locks
left a comment
There was a problem hiding this comment.
Great work @ziggythehamster! Thank you for the thoroughness and going back all the way to 1.0!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep finding myself finding stuff in the docs that I have to double-check to see if the version of Ember I'm using actually supports. Today, the thing I was looking at was in Ember.Route, and the docs were missing
@sincetags, so I had to check the source of Ember 1.10 to see if I could actually use it. I can.This PR adds
@sinceto all public APIs in Ember.Route, even when it's been there since 1.0.0, so that users like myself that aren't on the latest version can be sure that the thing that might solve our problem is available in our version of Ember.I checked 0.9 out, and it seems like there wasn't a concept of a route in 0.9 (oh how far we've come!), so I didn't bother checking any earlier than 1.0.0. If I should have, let me know and I'll give it another whirl.