Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial d8-runner ready to go #14454

Merged
merged 2 commits into from
Oct 30, 2016
Merged

initial d8-runner ready to go #14454

merged 2 commits into from
Oct 30, 2016

Conversation

stefanpenner
Copy link
Member

No description provided.

@krisselden
Copy link
Contributor

I don't understand why the node dom helper isn't being chosen. You shouldn't need the dom patches, and they will not work if something actually uses {{{html}}}

@krisselden
Copy link
Contributor

Otherwise, awesome work.

@stefanpenner
Copy link
Member Author

stefanpenner commented Oct 12, 2016

I don't understand why the node dom helper isn't being chosen. You shouldn't need the dom patches, and they will not work if something actually uses {{{html}}}

I was having a hard time debugging in D8. Maybe we can sit down later today or tomorrow and address what you pointed out.

  • We obviously want to make sure this uses the Node dom helper stuff, i don't think it is yet.

@rwjblue
Copy link
Member

rwjblue commented Oct 30, 2016

@stefanpenner - Any reason not to land this and iterate further while on master?

@stefanpenner
Copy link
Member Author

stefanpenner commented Oct 30, 2016

@rwjblue no reason, but if we do then we should then likely open an issue for:

We obviously want to make sure this uses the Node dom helper stuff, i don't think it is yet.

That way we don't forget about it

@stefanpenner stefanpenner merged commit 62a2c1c into master Oct 30, 2016
@stefanpenner stefanpenner deleted the d8 branch October 30, 2016 14:34
@stefanpenner
Copy link
Member Author

#14551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants